AST-76: implement shorthand variants with unit payload#310
Merged
mergify[bot] merged 7 commits intomasterfrom Apr 15, 2019
Merged
AST-76: implement shorthand variants with unit payload#310mergify[bot] merged 7 commits intomasterfrom
mergify[bot] merged 7 commits intomasterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dfinity.atlassian.net/browse/AST-76
https://dfinity.atlassian.net/browse/AST-42
These mimic enumerated types in other languages.
We treat them as nullary patterns/expressions in the parser,
so no parenthesising is necessary.
One decision I made is to equip the implicit units with the source location of the variant tags. This might be confusing for debuggers later (?), but possibly helpful for (type)error messages, i.e. point the user to the right place when unit is not the correct type.
Laundry list:
debug_showshould use shorthand.